Do not request local execution from Rust SDK #19373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
lxfind
force-pushed
the
rust-sdk-deprecate-local-execution
branch
from
4baa450 to
a71ccd3
Compare
stefan-mysten
approved these changes
Sep 13, 2024
lxfind
force-pushed
the
rust-sdk-deprecate-local-execution
branch
from
a71ccd3 to
1657eea
Compare
bmwill
approved these changes
Sep 16, 2024
lxfind
force-pushed
the
rust-sdk-deprecate-local-execution
branch
from
1657eea to
91695f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the code below these lines we emulate local execution by polling the transaction.
This means that we no longer need to pass through the request type to the RPC server, otherwise if user specified WaitForLocalExecution it would still be passed through.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.